Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entity cache #990

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Fix entity cache #990

merged 1 commit into from
Aug 26, 2020

Conversation

steven-sheehy
Copy link
Member

Detailed description:

  • Fix regression with not caching entity lookups during transaction parsing
  • Port of Fix entity cache #989 to master

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@steven-sheehy
Fix entity cache
815e124 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 regression parser Area: File parsing transactions File: Related to processing of transaction record stream file labels Aug 26, 2020
@steven-sheehy steven-sheehy added this to the Mirror 0.18.0 milestone Aug 26, 2020
@steven-sheehy steven-sheehy requested a review from a team August 26, 2020 22:57
@steven-sheehy steven-sheehy self-assigned this Aug 26, 2020
Nana-EC
Nana-EC approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 26, 2020 •
edited
Loading

Codecov Report

Merging #990 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #990   +/-   ##
=========================================
  Coverage     86.57%   86.57%           
  Complexity      211      211           
=========================================
  Files           176      176           
  Lines          4386     4386           
  Branches        494      494           
=========================================
  Hits           3797     3797           
  Misses          437      437           
  Partials        152      152
Impacted Files Coverage Δ Complexity Δ
...r/importer/config/MetricsExecutionInterceptor.java 82.35% <0.00%> (-1.48%) 0.00% <0.00%> (ø%)
...irror/importer/parser/record/RecordFileParser.java 90.52% <0.00%> (+1.05%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2c8b2...815e124. Read the comment docs.

@steven-sheehy steven-sheehy merged commit a5f41da into master Aug 26, 2020
@steven-sheehy steven-sheehy deleted the fix-entity-cache-master branch August 26, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

Assignees

@steven-sheehy steven-sheehy

Labels
bug Type: Something isn't working P1 parser Area: File parsing regression transactions File: Related to processing of transaction record stream file
Projects
None yet
Milestone
Mirror 0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@steven-sheehy @Nana-EC